Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent functions from throwing loop control flow exceptions; convert them into StormRuntimeError. SYN-8397 #4025

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Prevent functions from throwing loop control flow exceptions; convert them into StormRuntimeError. SYN-8397 #4025

wants to merge 36 commits into from

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (1813952) to head (993025d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
- Coverage   96.48%   96.40%   -0.08%     
==========================================
  Files         256      256              
  Lines       59645    59711      +66     
==========================================
+ Hits        57547    57563      +16     
- Misses       2098     2148      +50
Flag Coverage Δ
linux 96.40% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invisig0th
invisig0th reviewed Dec 5, 2024
View reviewed changes
synapse/lib/ast.py Outdated Show resolved Hide resolved
Cisphyx
Cisphyx reviewed Dec 5, 2024
View reviewed changes
synapse/lib/ast.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte added the bug label Dec 31, 2024
@vEpiphyte vEpiphyte marked this pull request as ready for review December 31, 2024 04:52
MichaelSquires
MichaelSquires reviewed Dec 31, 2024
View reviewed changes
changes/b4642a502f49353787b4f6632a6a6566.yaml Outdated Show resolved Hide resolved
synapse/lib/stormctrl.py Outdated Show resolved Hide resolved
synapse/lib/stormctrl.py Outdated Show resolved Hide resolved
vEpiphyte and others added 3 commits December 31, 2024 11:20
Cisphyx
Cisphyx reviewed Jan 3, 2025
View reviewed changes
synapse/lib/stormctrl.py Outdated Show resolved Hide resolved
Cisphyx
Cisphyx reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@Cisphyx Cisphyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely related to this fix but emit usage outside of emitter functions is missing highlight info.

MichaelSquires
MichaelSquires previously approved these changes Jan 6, 2025
View reviewed changes
@vEpiphyte vEpiphyte added this to the v2.194.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSquires MichaelSquires MichaelSquires approved these changes

@Cisphyx Cisphyx Cisphyx approved these changes

@invisig0th invisig0th Awaiting requested review from invisig0th

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.194.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vEpiphyte @invisig0th @Cisphyx @MichaelSquires