resolve scheduler loop error (SYN-7132) #4058
Draft
+202
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2025 14:38
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4058 +/- ##
==========================================
- Coverage 96.48% 96.39% -0.09%
==========================================
Files 256 256
Lines 59645 59682 +37
==========================================
- Hits 57547 57531 -16
- Misses 2098 2151 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
invisig0th
reviewed
Jan 9, 2025
| @@ -707,7 +708,20 @@ async def clearRunningStatus(self): | |||
| for appt in list(self.appts.values()): | |||
| if appt.isrunning: | |||
| logger.debug(f'Clearing the isrunning flag for {appt.iden}') | |||
| await self.core.addCronEdits(appt.iden, {'isrunning': False}) | |||
| edits = { | |||
There was a problem hiding this comment.
This edits update definitely seems like the key 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.