Skip to content

Ensure that getUserDef / getRoleDef is deepcopied (SYN-8627)#4084

Merged
vEpiphyte merged 2 commits intomasterfrom
bug_auth_pack_authgates
Jan 24, 2025
Merged

Ensure that getUserDef / getRoleDef is deepcopied (SYN-8627)#4084
vEpiphyte merged 2 commits intomasterfrom
bug_auth_pack_authgates

Conversation

@vEpiphyte
Copy link
Contributor

These API results values should be unique and changes to them should not reflect back on any in-memory structures.

@vEpiphyte vEpiphyte added the bug label Jan 24, 2025
@vEpiphyte vEpiphyte added this to the v2.195.0 milestone Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (07e8f45) to head (be21ba4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
- Coverage   96.47%   96.40%   -0.08%     
==========================================
  Files         256      256              
  Lines       59807    59809       +2     
==========================================
- Hits        57700    57660      -40     
- Misses       2107     2149      +42     
Flag Coverage Δ
linux 96.40% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MichaelSquires
MichaelSquires previously approved these changes Jan 24, 2025
OCBender
OCBender previously approved these changes Jan 24, 2025
@Cisphyx Cisphyx dismissed stale reviews from OCBender and MichaelSquires via be21ba4 January 24, 2025 14:11
@vEpiphyte vEpiphyte merged commit 0bc4217 into master Jan 24, 2025
3 checks passed
@vEpiphyte vEpiphyte deleted the bug_auth_pack_authgates branch January 24, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants