Enabling test learning curve (#750)

* The issue causing the TestModelSelection::test_learning_curve failure is fixed in Vertica 23.4 * make the vertica version be displayed
vertica · Oct 17, 2023 · 60bdb72 · 60bdb72
1 parent 574bfae
commit 60bdb72
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -23,7 +23,7 @@ jobs:
       - name: Set up a Vertica server
         timeout-minutes: 15
         run: |
-          docker pull vertica/vertica-ce:23.3.0-0
+          docker pull vertica/vertica-ce:latest
           docker run -d -p 5433:5433 -p 5444:5444 \
             --name vertica_docker \
             vertica/vertica-ce
@@ -34,6 +34,7 @@ jobs:
           done;
           echo "Vertica is up"
           docker exec -u dbadmin vertica_docker /opt/vertica/bin/vsql -c "\l"
+          docker exec -u dbadmin vertica_docker /opt/vertica/bin/vsql -c "select version();"
       - name: Install dependencies
         run: pip install tox
       - name: Run tests

diff --git a/.github/workflows/master-codecov.yml b/.github/workflows/master-codecov.yml
@@ -21,7 +21,7 @@ jobs:
       - name: Set up a Vertica server
         timeout-minutes: 15
         run: |
-          docker pull vertica/vertica-ce:23.3.0-0
+          docker pull vertica/vertica-ce:latest
           docker run -d -p 5433:5433 -p 5444:5444 \
             --name vertica_docker \
             vertica/vertica-ce
@@ -32,6 +32,7 @@ jobs:
           done;
           echo "Vertica is up"
           docker exec -u dbadmin vertica_docker /opt/vertica/bin/vsql -c "\l"
+          docker exec -u dbadmin vertica_docker /opt/vertica/bin/vsql -c "select version();"
       - name: Install dependencies
         run: pip install tox
       - name: Run tests

diff --git a/verticapy/tests/vModel/test_model_selection.py b/verticapy/tests/vModel/test_model_selection.py
@@ -326,7 +326,6 @@ def test_validation_curve(self, winequality_vd):
         assert len(result["test_score"]) == 3
         assert len(result.values) == 7
 
-    @pytest.mark.skip(reason="needs some investigation")
     def test_learning_curve(self, winequality_vd):
         for elem in ["efficiency", "performance", "scalability"]:
             result = learning_curve(