Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docstring for memmodel.cluster.py #752

Closed

Conversation

abhsharma2
Copy link
Collaborator

No description provided.

@oualib oualib requested a review from mail4umar October 19, 2023 18:53
Copy link
Member

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please review the formatting of your '=' signs and it seems that your lines are too long for the black formatting.

verticapy/machine_learning/memmodel/cluster.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/cluster.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/cluster.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/cluster.py Outdated Show resolved Hide resolved
@oualib
Copy link
Member

oualib commented Oct 20, 2023

@mail4umar please double check this PR and see if it is working on your side

res = model_bkm.plot_tree()
res.render(filename='figures/machine_learning_cluster_bisecting_kmeans', format='png')

.. image:: SPHINX_DIRECTORY/figures/machine_learning_cluster_bisecting_kmeans.png
Copy link
Collaborator

@mail4umar mail4umar Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image directive uses source as the base path. so the image path should be relative.

.. image:: /../figures/machine_learning_cluster_bisecting_kmeans.png

Copy link
Collaborator

@mail4umar mail4umar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the plot_tree fix is left

@mail4umar mail4umar closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants