Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oudated comment in seqs.rs #1414

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Remove oudated comment in seqs.rs #1414

merged 2 commits into from
Jan 28, 2025

Conversation

ahuoguo
Copy link
Collaborator

@ahuoguo ahuoguo commented Jan 27, 2025

From #1317, seq! with more than one element now doesn't encode to .push, which makes the comments here false.

Sidenote: the last test in seqs.rs:

            // Test for successful broadcast of push_distributes_over_add
            assert((s2 + s4).push(120) == s2 + s4.push(120));

doesn't seem to be a useful test sine this assertion still verifies if push_distributes_over_add is removed from group_seq_lib_default. It verifies with the following axiom-usage-info:

note: checking this function used these broadcasted lemmas and broadcast groups:
        - (group) vstd::seq::group_seq_axioms,
        - (group) vstd::seq_lib::group_seq_lib_default,
        - (group) vstd::group_vstd_default,
        - vstd::seq::axiom_seq_push_len,
        - vstd::seq::axiom_seq_push_index_same,
        - vstd::seq::axiom_seq_push_index_different,
        - vstd::seq::axiom_seq_ext_equal,
        - vstd::seq::axiom_seq_add_len,
        - vstd::seq::axiom_seq_add_index1,
        - vstd::seq::axiom_seq_add_index2,
        - vstd::seq_lib::impl&%0::filter_lemma,
        - vstd::seq_lib::impl&%0::filter_distributes_over_add

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@ahuoguo ahuoguo changed the title Remove oudated comment Remove oudated comment in seqs.rs Jan 27, 2025
@utaal
Copy link
Collaborator

utaal commented Jan 27, 2025

Is the side-note relevant to this PR? Perhaps add a TODO in the PR with the comment, so we can keep track of it, if it's not something we want to handle in this PR.

@ahuoguo ahuoguo marked this pull request as ready for review January 27, 2025 19:38
@utaal utaal merged commit 8402a97 into main Jan 28, 2025
11 checks passed
@utaal utaal deleted the update_seqs_test branch January 28, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants