Support slice::get && Ignore trait predicates when not visible to local. #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Why: trait SliceIndex<T: ?Sized>: private_slice_index::Sealed * Add spec for slice::get
| let mut visible = tcx.visibility(td.def_id).is_visible_locally(); | ||
| let mut def_id = td.def_id; | ||
| while let Some(parent_def_id) = tcx.opt_parent(def_id) { | ||
| if !tcx.visibility(parent_def_id).is_visible_locally() { |
There was a problem hiding this comment.
It looks like this is rejecting some traits that actually are visible, like Iterator:
td.def_id = DefId(2:8781 ~ core[145f]::iter::traits::iterator::Iterator)
parent_def_id = DefId(2:8736 ~ core[145f]::iter::traits::iterator)
In https://github.com/rust-lang/rust/blob/master/library/core/src/iter/traits/mod.rs , it looks like Iterator is made visible via a pub use after being initially declared in a private module:
mod accum;
mod collect;
mod double_ended;
mod exact_size;
mod iterator;
mod marker;
mod unchecked_iterator;
#[unstable(issue = "none", feature = "inplace_iteration")]
pub use self::marker::InPlaceIterable;
#[unstable(issue = "none", feature = "trusted_fused")]
pub use self::marker::TrustedFused;
#[unstable(feature = "trusted_step", issue = "85731")]
pub use self::marker::TrustedStep;
pub(crate) use self::unchecked_iterator::UncheckedIterator;
#[stable(feature = "rust1", since = "1.0.0")]
pub use self::{
accum::{Product, Sum},
collect::{Extend, FromIterator, IntoIterator},
double_ended::DoubleEndedIterator,
exact_size::ExactSizeIterator,
iterator::Iterator,
marker::{FusedIterator, TrustedLen},
};
There was a problem hiding this comment.
Oh. I see. Then I do not know how to check whether a trait is reacheable. I did not find a correct helper function from TyCtxt. Maybe do a hard check on path?
let path = tcx.def_path_str(tp.trait_ref.def_id);
if path == "core::slice::index::private_slice_index::Sealed" {
false
} else if
Chris-Hawblitzel
approved these changes
Feb 11, 2025
| if !visible { | ||
| // Skip private trait bounds | ||
| let path = tcx.def_path_str(tp.trait_ref.def_id); | ||
| if path == "core::slice::index::private_slice_index::Sealed" { |
There was a problem hiding this comment.
This would be better as a call to verus_items::get_rust_item, but otherwise it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.