Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add labels for nodegroup name and role name #167

Merged
merged 2 commits into from
Jul 20, 2023
Merged

feat: Add labels for nodegroup name and role name #167

merged 2 commits into from
Jul 20, 2023

Conversation

okozachenko1203
Copy link
Member

@okozachenko1203 okozachenko1203 commented Jul 18, 2023 •
edited
Loading

fix #164

@okozachenko1203
Copy link
Member Author

Tested on my local.

@okozachenko1203
Copy link
Member Author

image
role field added for master and worker correctly also with our new labels.

@mnaser mnaser merged commit a4e6d03 into main Jul 20, 2023
26 checks passed
@mnaser mnaser deleted the add-role branch July 20, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for adding magnum.openstack.org/role role to nodes.
2 participants
@okozachenko1203 @mnaser