Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/364 prevent reads shuffle #386

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

ducku
Copy link
Collaborator

@ducku ducku commented Jan 14, 2024

Reads outside of nodes are sorted by order, then a previous y value. However, consecutive reads outside of nodes have their y values computed simultaneously, resulting in the previous y value still being null. This resulted in consecutive read segments outside of nodes that have the same order value being randomly sorted.

Fix: Go back through the path and find the last computed y value(from the last visited node), and use that to sort segments.

Closes #364

chr6:82003584-82004084

Capture

Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I am just going to slightly tinker with the logic.

src/util/tubemap.js Outdated Show resolved Hide resolved
@adamnovak adamnovak merged commit 17c69e5 into vgteam:master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reads skipping multiple nodes do a nonsensical shuffle
2 participants