Open
Conversation
added reference to flashtext paper
added citation
corrected citation
`charactes` | `characters` `explaination` | `explanation` `matche` | `match`
Fix issue with incomplete keyword at the end of the sentence
Performances improvement for strings manipulations
Owner
|
Can you please resolve the conflict. |
HCYT
added a commit
to termdock/flashtext-i18n
that referenced
this pull request
Jan 13, 2026
Problem: - Keywords like '地中海贫血' were not extracted from '地中海贫血2' - Numbers (0-9) are in non_word_boundaries, causing the match to fail Root cause: - The algorithm required the next character to be a word boundary - But for CJK, the keyword's last character itself is already a boundary Solution: - Check if the last matched character is not in non_word_boundaries (CJK) - If so, accept the match regardless of what follows - This preserves English word boundary semantics while fixing CJK Fixes: #1 Ref: upstream vi3k6i5/flashtext#87, vi3k6i5/flashtext#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG 1:
import flashtext
_extractor = flashtext.KeywordProcessor()
_extractor.add_keyword('地中海贫血')
True
_extractor.extract_keywords('地中海贫血')
['地中海贫血']
_extractor.extract_keywords('地中海贫血2')
[]
BUG2:
import flashtext
_extractor = flashtext.KeywordProcessor()
_extractor.add_keyword('头疼')
_extractor.add_keyword('头晕')
True
_extractor.extract_keywords('头疼头晕')
['头疼']