Added Book model, repository & service layers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrocherepov
approved these changes
Oct 14, 2023
Comment on lines
28
to
94
| public Long getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public void setId(Long id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
| public String getTitle() { | ||
| return title; | ||
| } | ||
|
|
||
| public void setTitle(String title) { | ||
| this.title = title; | ||
| } | ||
|
|
||
| public String getAuthor() { | ||
| return author; | ||
| } | ||
|
|
||
| public void setAuthor(String author) { | ||
| this.author = author; | ||
| } | ||
|
|
||
| public String getIsbn() { | ||
| return isbn; | ||
| } | ||
|
|
||
| public void setIsbn(String isbn) { | ||
| this.isbn = isbn; | ||
| } | ||
|
|
||
| public BigDecimal getPrice() { | ||
| return price; | ||
| } | ||
|
|
||
| public void setPrice(BigDecimal price) { | ||
| this.price = price; | ||
| } | ||
|
|
||
| public String getDescription() { | ||
| return description; | ||
| } | ||
|
|
||
| public void setDescription(String description) { | ||
| this.description = description; | ||
| } | ||
|
|
||
| public String getCoverImage() { | ||
| return coverImage; | ||
| } | ||
|
|
||
| public void setCoverImage(String coverImage) { | ||
| this.coverImage = coverImage; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Book{" | ||
| + "id=" + id | ||
| + ", title='" + title + '\'' | ||
| + ", author='" + author + '\'' | ||
| + ", isbn='" + isbn + '\'' | ||
| + ", price=" + price | ||
| + '}'; | ||
| } | ||
| } |
There was a problem hiding this comment.
you can just use @DaTa annotation on your class ) It's up to you
There was a problem hiding this comment.
You added Lombok annotation but didn’t use it. Lombok is a great library but be attentive when using it with Entity JFYI
liliia-ponomarenko
suggested changes
Oct 16, 2023
Comment on lines
28
to
94
| public Long getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public void setId(Long id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
| public String getTitle() { | ||
| return title; | ||
| } | ||
|
|
||
| public void setTitle(String title) { | ||
| this.title = title; | ||
| } | ||
|
|
||
| public String getAuthor() { | ||
| return author; | ||
| } | ||
|
|
||
| public void setAuthor(String author) { | ||
| this.author = author; | ||
| } | ||
|
|
||
| public String getIsbn() { | ||
| return isbn; | ||
| } | ||
|
|
||
| public void setIsbn(String isbn) { | ||
| this.isbn = isbn; | ||
| } | ||
|
|
||
| public BigDecimal getPrice() { | ||
| return price; | ||
| } | ||
|
|
||
| public void setPrice(BigDecimal price) { | ||
| this.price = price; | ||
| } | ||
|
|
||
| public String getDescription() { | ||
| return description; | ||
| } | ||
|
|
||
| public void setDescription(String description) { | ||
| this.description = description; | ||
| } | ||
|
|
||
| public String getCoverImage() { | ||
| return coverImage; | ||
| } | ||
|
|
||
| public void setCoverImage(String coverImage) { | ||
| this.coverImage = coverImage; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Book{" | ||
| + "id=" + id | ||
| + ", title='" + title + '\'' | ||
| + ", author='" + author + '\'' | ||
| + ", isbn='" + isbn + '\'' | ||
| + ", price=" + price | ||
| + '}'; | ||
| } | ||
| } |
There was a problem hiding this comment.
You added Lombok annotation but didn’t use it. Lombok is a great library but be attentive when using it with Entity JFYI
| import org.bookstore.model.Book; | ||
|
|
||
| public interface BookRepository { | ||
|
|
There was a problem hiding this comment.
To be honest I don’t prefer to leave one empty line after class declaration but you can do it if you like it BUT!!! make it consistent (leave one empty line in each class or remove it everywhere)
| public class BookRepositoryImpl implements BookRepository { | ||
| private final SessionFactory sessionFactory; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
As of Spring Framework 4.3, an @Autowired annotation on such a constructor is no longer necessary if the target bean defines only one constructor to begin with. See note here Let’s check it ;)
viacheslav-torbin
requested review from
liliia-ponomarenko,
dmytrocherepov and
TetianaDenchyk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.