Add vial support for Akko Top40 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vial port for Akko Top40 keyboard, https://en.akkogear.com/product/acr-top-40/
adophoxia
suggested changes
Oct 1, 2023
Remove redundunt #define's due to VIALRGB_ENABLE = yes in rules.mk Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Remove unnesessary optimization Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Enable Cherry MX Lock switches support Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
adophoxia
approved these changes
Oct 1, 2023
|
Thank you for review. |
lesshonor
approved these changes
Oct 1, 2023
Crandel
pushed a commit
to Crandel/vial-qmk
that referenced
this pull request
Oct 12, 2023
* Add vial support for Akko Top40 Vial port for Akko Top40 keyboard, https://en.akkogear.com/product/acr-top-40/ * Update keyboards/akko/top40/keymaps/vial/config.h Remove redundunt #define's due to VIALRGB_ENABLE = yes in rules.mk Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/rules.mk Remove unnesessary optimization Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/config.h Enable Cherry MX Lock switches support Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> --------- Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
zhol0777
pushed a commit
to zhol0777/vial-qmk
that referenced
this pull request
Nov 20, 2023
* Add vial support for Akko Top40 Vial port for Akko Top40 keyboard, https://en.akkogear.com/product/acr-top-40/ * Update keyboards/akko/top40/keymaps/vial/config.h Remove redundunt #define's due to VIALRGB_ENABLE = yes in rules.mk Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/rules.mk Remove unnesessary optimization Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/config.h Enable Cherry MX Lock switches support Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> --------- Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
janvladimirmostert
pushed a commit
to janvladimirmostert/vial-qmk-chameleon
that referenced
this pull request
Dec 1, 2023
* Add vial support for Akko Top40 Vial port for Akko Top40 keyboard, https://en.akkogear.com/product/acr-top-40/ * Update keyboards/akko/top40/keymaps/vial/config.h Remove redundunt #define's due to VIALRGB_ENABLE = yes in rules.mk Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/rules.mk Remove unnesessary optimization Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> * Update keyboards/akko/top40/keymaps/vial/config.h Enable Cherry MX Lock switches support Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> --------- Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vial port for Akko Top40 keyboard,
https://en.akkogear.com/product/acr-top-40/