Add support for foostan Cornelius #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
suggested changes
Nov 8, 2023
There was a problem hiding this comment.
Not to be harsh...but even if this file provided crucial information, no one is going to bother looking at it. IMO, might as well delete.
There was a problem hiding this comment.
I just kept it around since it was there in the default keymap and I didn't change much about it... Will delete, thx.
|
the mostly empty readme file needs to be deleted |
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
|
I only kept the empty readme around since it was part of the original "default" keymap in QMK - removed it now. |
lesshonor
approved these changes
Nov 22, 2023
LukeDRussell
pushed a commit
to LukeDRussell/vial-qmk
that referenced
this pull request
Dec 7, 2023
* add vial support for foostan cornelius * changed unlock sequence to enter key * Update keyboards/foostan/cornelius/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/foostan/cornelius/keymaps/vial/vial.json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * removed almost empty readme --------- Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Port for Boardsource Unicorne. Update keyboards/boardsource/unicorne/keymaps/vial/keymap.json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Update keyboards/boardsource/unicorne/keymaps/vial/vial.json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Port for Boardsource Unicorne. Update keyboards/boardsource/unicorne/keymaps/vial/keymap.json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Update keyboards/boardsource/unicorne/keymaps/vial/vial.json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a vial keymap for the foostan cornelius board. It was tested on hardware and cornfirmed working. The keymap mirros the default/VIA keymaps upstream by foostan, since I believe these should be the default.