Lotus 58, Vial keymap #591
Conversation
Replacing key-codes to match latest QMK iteration, some options are moved to .JSON
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Simplified OLED, cleaned up keymap
There was a problem hiding this comment.
I forgot to mention this in my original comment: if you really only want to provide this keymap for nanoboot, you can put it into a keymaps folder under nanoboot—i.e., keyboards/tweetydabird/lotus58/nanoboot/keymaps/vial.
But if I was you I would just selectively disable more features in the rules.mk. E.g.
# Reduce size on atmega32u4
ifeq ($(strip $(MCU)), atmega32u4)
TAP_DANCE_ENABLE = no
QMK_SETTINGS = no
KEY_OVERRIDE_ENABLE = no
COMBO_ENABLE = no
# Reduce size even more for non-nanoboot bootloaders
ifneq ($(strip $(BOOTLOADER_SIZE)), 512)
MAGIC_ENABLE = no
MOUSEKEY_ENABLE = no
endif
endif
|
Yep, working on it and testing. Unfortunately a trip to the vet with the family cat got in between. Feeling a bit low right now, so I'll pick up later. |
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
There was a problem hiding this comment.
The keyboard-level change here is quite reasonable as the same change is being made in an in-progress QMK PR.
| "name": "Lotus 58 Glow VIAL", | ||
| "author": "Markus Knutsson", | ||
|
|
There was a problem hiding this comment.
| "name": "Lotus 58 Glow VIAL", | |
| "author": "Markus Knutsson", | |
Technically not necessary for Vial.
There was a problem hiding this comment.
No, not necessary, but very beneficial as it shows as the device name in most OS's. Meaning it's easy to identify if a keyboard is flashed with vial or QMK.
There was a problem hiding this comment.
That isn't determined by vial.json, but by info.json. The Vial GUI concatenates manufacturer with keyboard_name.
.
(I hope your cat is doing better. If that isn't the case, my sympathies.)
There was a problem hiding this comment.
Hmmm. Ok. Then we are editing that.
No, unfortunately after 17 years of life, out of which 8 being my daughters life long companion/slash teddy bear/snuggle cat, she past. So yeah, cry fest.
* adding vial id * Update Vial keymap Replacing key-codes to match latest QMK iteration, some options are moved to .JSON * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Simplified OLED, cleaned up keymap Simplified OLED, cleaned up keymap * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Update keyboards/tweetydabird/lotus58/keymaps/vial/keymap.c Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * conditional --------- Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Adding Vial keymap, updated to latest QMK keycodes and moved appropriate settings to info.JSON
BTW, the two options failing in compile is due to lack of space using default bootloaders, and aren't viable as targets for Vial. So either these can be ignored, or someone can show me how to 'turn them off'?