[RSDK-9981] - implement blurry classifier #3
Conversation
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
I haven't looked at the "real" code yet, but here's feedback around the edges
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
I've got 1 more file to go, but it's the main file.
I worry that some of my feedback is too nitpicky. You're welcome to say "I hear your point, Alan, but I'm not going to do it." These are suggestions, not commands.
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
Most of this feedback is minor nitpicks and you can ignore anything you don't like. but the part about what confidence we return is important.
and changing the confidence returned might change the behavior of the tests. I'd just assert that the confidence returned is in the range of values we expect it to be near.
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
LGTM! All my remaining feedback is easy to resolve (though some of it is still pretty important).
|
|
||
| . venv/bin/activate | ||
|
|
||
| ## using `pyrhon -m PyInastaller` as opposed to `pyinstaller` as the former |
There was a problem hiding this comment.
😆 pyrhon -m PyInastaller should be fixed next PR
|
|
||
| if __name__ == "__main__": | ||
| asyncio.run(main()) | ||
| asyncio.run(Module.run_from_registry()) |
There was a problem hiding this comment.
Dang, this is way nicer than it used to be! Good idea
Future Actions