RSDK-12683: Get Kinematics for Gantry #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
requested changes
Dec 15, 2025
| * Viam's kinematic parameter format (spatial vector algebra) (``KinematicsFileFormat.KINEMATICS_FILE_FORMAT_SVA``), | ||
| * and the second [1] value represents the byte contents of the file. | ||
| */ | ||
| abstract fun getKinematics(extra: Struct): Pair<KinematicsFileFormat, ByteString> |
Member
There was a problem hiding this comment.
Let's use native bytes rather than protobuf ByteString
Member
Author
There was a problem hiding this comment.
sounds good, I copied how it was implemented for getKinematics for arm so I'll update those bytes as well
stuqdog
approved these changes
Dec 15, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
looks reasonable to me, modulo Naveed's comment
njooma
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.