Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update module augmentation #146

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(types): update module augmentation #146

merged 1 commit into from
Apr 17, 2024

Conversation

dargmuesli
Copy link
Contributor

@dargmuesli dargmuesli commented Apr 16, 2024

Since nuxt/nuxt#26541 multiple modules need to be augmented for type checking to continue working as expected.

The mentioned PR is included in Nuxt starting with version 3.11.2.

Since nuxt/nuxt#26541 multiple modules need to be augmented for type checking to continue working as expected.
@dargmuesli
Copy link
Contributor Author

Example of a failing workflow in a PR that update Nuxt from 3.11.1 to 3.11.2: https://github.com/maevsi/maevsi/actions/runs/8714930888/job/23906009601?pr=1576#step:7:835

@victorgarciaesgi
Copy link
Owner

Oh good catch! That's why it failed and i think #143 is related

@victorgarciaesgi
Copy link
Owner

Testing this and releasing asap

@victorgarciaesgi victorgarciaesgi merged commit 64c71e9 into victorgarciaesgi:master Apr 17, 2024
1 of 2 checks passed
@dargmuesli dargmuesli deleted the patch-1 branch April 17, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants