Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): release 1.5.0 #394

Merged

Conversation

vicwomg
Copy link
Owner

@vicwomg vicwomg commented Sep 4, 2024

🤖 I have created a release beep boop

1.5.0 (2024-09-04)

Features

  • add messages.mo file for es_VE translation (3cd7d26)

Bug Fixes

  • song number overflows to add button when > 999 songs #379 (a53c9e0)

Documentation

  • move TROUBLESHOOTING to wiki (331e814)
  • readme: recommend Bookworm OS over bullseye (15598f2)

This PR was generated with Release Please. See documentation.

@vicwomg
Copy link
Owner Author

vicwomg commented Sep 4, 2024

@mariugul Once again seems like I don't know what I'm doing with commit messages. Why did this bump to 1.5 ? Is it the "feat:" tag?

These are the commits:

commit 488f308adf32ab72544755793b11476004fcf162 (HEAD -> documentation-and-various-fixes, origin/documentation-and-various-fixes)
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 12:02:40 2024 -0700

    fix: song number overflows to add button when > 999 songs #379

commit 0e8118462c7826d90fe3512f34a7cdbfbee81bd0
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:52:39 2024 -0700

    feat: add messages.mo file for es_VE translation

commit 3335aee47140e3fe9d448d81930d7c2880fb4359
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:47:16 2024 -0700

    docs(readme): recommend Bookworm OS over bullseye

commit a7065fca5d6933ca7172ce5611e3d21bc11a5319
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:39:31 2024 -0700

    docs: move TROUBLESHOOTING to wiki

@mariugul
Copy link
Collaborator

mariugul commented Sep 4, 2024

@mariugul Once again seems like I don't know what I'm doing with commit messages. Why did this bump to 1.5 ? Is it the "feat:" tag?

These are the commits:

commit 488f308adf32ab72544755793b11476004fcf162 (HEAD -> documentation-and-various-fixes, origin/documentation-and-various-fixes)
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 12:02:40 2024 -0700

    fix: song number overflows to add button when > 999 songs #379

commit 0e8118462c7826d90fe3512f34a7cdbfbee81bd0
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:52:39 2024 -0700

    feat: add messages.mo file for es_VE translation

commit 3335aee47140e3fe9d448d81930d7c2880fb4359
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:47:16 2024 -0700

    docs(readme): recommend Bookworm OS over bullseye

commit a7065fca5d6933ca7172ce5611e3d21bc11a5319
Author: Vic Wong <vicwong@gmail.com>
Date:   Wed Sep 4 10:39:31 2024 -0700

    docs: move TROUBLESHOOTING to wiki

Yes it's because you used feat which means a feature also known as minor increment. Release Please triggers on only 2 keywords (actually 3 but don't focus on the last one). That is feat and fix.

  1. If you do a bugfix, make a commit starting with fix.
  2. If you do a new feature implementation that adds features and doesn't break backwards compatibility, that's a feat.
  3. If you do a major breaking change feature that's a feat! <summary> with a body saying BREAKING-CHANGE:. This is backwards breaking or API breaking changes.

That's basically it. So if you didn't actually make a feature it shouldn't be feat but something else. Perhaps refactorif you refactored or a chore if it's just some repo stuff or a docs if it's documentation.

The last keyword Release Please triggers on is deps but it's rarely used. You can use it if you update the dependencies of the package for example.

@mariugul
Copy link
Collaborator

mariugul commented Sep 4, 2024

If you made a mistake you can just close this PR and revert your changes and re-commit.

@vicwomg
Copy link
Owner Author

vicwomg commented Sep 4, 2024

Hmm, well given my options adding spanish language support sounds like more a feat than anything else. I suppose this is "correct"

@vicwomg vicwomg merged commit 50a15e7 into master Sep 4, 2024
5 checks passed
@vicwomg
Copy link
Owner Author

vicwomg commented Sep 4, 2024

🤖 Created releases:

@mariugul
Copy link
Collaborator

mariugul commented Sep 4, 2024

Hmm, well given my options adding spanish language support sounds like more a feat than anything else. I suppose this is "correct"

Then great 😄 I agree it's a feature if you added support for something that didn't exist.

@mariugul mariugul deleted the release-please--branches--master--components--pikaraoke branch September 4, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants