Fix flash in Firefox using latest Clappr (0.2.85) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philcrump can you tell me what's missing in your environment so we can do a full test before bumping a new version? |
|
Apologies, I'm in a linux environment so I don't have AirSDK available. These changes shouldn't touch the SWF and I have tested successfully by just doing the webpack step which produces the relevant files of assets/flash.html, rtmp.min.js & rtmp.min.js.map. The outputs are now what I'm using in production. However I didn't want to commit an incomplete build. I can possibly spin up a windows VM to get AirSDK running if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48 .
Simply ported the fixes from clappr/clappr@6f18eaa
Tested successfully with manual edits of dist/ using FF 57.0 and Chrome 63 on Ubuntu.
Unfortunately I don't have the environment to follow the full build process.