Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent set disabled metadata TextTrack when create snapshot #545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nonth
Copy link

@nonth nonth commented Mar 31, 2023

Current behavior and problem

Before play ads that trigger by Cue Text Tracks the plugin create a player's snapshot in this process plugin store TextTrack in suppressedTracks array then set track mode to disabled to prevent TextTrack (subtitles?) to display on player when ads is playing after ads end the plugin restore player's snapshot and set TextTrack's mode back to original (before play ads)

After set TextTrack's mode back to original the browser see that TextTrack change from inactive to active it will trigger a cuechange event

The integration received cuechange event then it try to play ads and repeat the whole snapshot process again forever you can see this behavior in example link below

example

Solution

In this PR will not set metadata TextTrack mode to disabled since metadata TextTrack is not visible on player and it will prevent browser to forever trigger cuechange event

it's fixed the problem that I've mention above
example

@nonth nonth changed the title Prevent disabled metadata TextTrack when create snapshot Prevent set disabled metadata TextTrack when create snapshot Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant