Simple multi select/development #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es a new Simple Multi Select for them. Added functionality to transform a select element into our styles multi select. Flushed out main button styles and functionality for opening/closing the select options. Flushed out the select options styles. Added functionality for selecting/deselecting options. Added functionality for adding a "Select All" type option and having that work as expected. Added functionality and styles for disabled options. Add some icons from the Bootstrap Icon library into a folder with appropriate license info. Added aria labels to all elements.
…the selected options text.
Updated the InitializeAllMultiSelects function to ignore multiple selects that are wrapped in our wrapper.
…over/focus. Adjusted the padding on the button. Changed the multi select constructor so that it can accept null for the label. If null is passed in then a label is created. Added an onChangeCallback function that can be set through the constructor or through a public function registerOnChangeCallback. This function is passed the multiSelectID and a list of selected values.
… simple multi select documentation. Added documentation about the multi selects CSS variables, how to install and initialize the multiple selects. Added a custom documentation component to show examples of the multiple select.
…dden with an ellipsis shown. Documented the entire multi select class. Moved the logic for finding an associated label to its own function within the multi select and is used during the contructor of the class. Removed the label element to be passed in to the multi select class. Added a new public function get the currently selected values.
Fixed issues with importing local types. Updated tags in the package.json
Changesets created.
🦋 Changeset detectedLatest commit: 731b829 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial release of the Simple Multi-Select