Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Conversation

@stsewd
Copy link
Contributor

@stsewd stsewd commented Aug 15, 2021

No description provided.

Comment on lines +486 to +487

_escaped_line: ($) => alias($._line_continuation, '\\'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a place where this is used, is it normal ?
Maybe you reather want to change this in the extras key too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's normal, but it does help to show the tokens. Including _escaped_line in extras should be the correct way, but it leads to a long wait time when generating the grammar... we may want to ask the tree-sitter devs about this situation, may be a bug (updating the tree-sitter-cli doesn't help)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but what I mean is remove every instance of _line_continuation and replace it by _escaped_line in here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the on in externals and in this rule definition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_line_continuation is only used on externals

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants