-
-
Notifications
You must be signed in to change notification settings - Fork 31
Fix field identifiers #18
base: master
Are you sure you want to change the base?
Conversation
|
Found a bug with or smaller example but it works if there is a space |
a908fb3 to
3a4d04f
Compare
3a4d04f to
16633ba
Compare
|
OK, I give up for today, in vimscript the let a = foo.bar. '' " This breaks, but in vimscript it's a concatenation
let a = foo.bar.'' " This breaks, but in vimscript it's a concatenation
let a = foo.bar . '' " This is ok
let a = foo.bar . baz " This is ok
let a = foo.bar .baz " This is ok
let a = foo.bar. baz " This is marked as a field, but in vimscript it's a concatenationPreviously this was let a = foo.bar. '' " This is marked as a field with a string as value.
let a = foo.bar.'' " This is marked as a field with a string as value.
let a = foo.bar . '' " This is ok
let a = foo.bar . baz " This is ok
let a = foo.bar .baz " This is ok
let a = foo.bar. baz " This is marked as a field, but in vimscript it's a concatenationI'll try to play more whit this in the following days.... |
vigoux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am quite against that tbh, the docs specify that fields are actually expressions, thus that's what they should be.
|
Fields are horrible to work with because the |
That isn't what the docs say, this is what they say Only the first part is an expression, the second part after that is a name, not an expression. |
|
Indeed you are right. |
|
But in any case I preffer having the |
| field_expression: ($) => | ||
| field: ($) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point of renaming this appart from breaking backward compatibility.
Fields are more of an identifier rather than an expression, I have renamed it to reflect this.