fix(ci): update setup-deno action to v2 for Deno 2.x compatibility #293

lambdalisue · 2025-09-28T17:16:41Z

🎯 Purpose

Fix CI failures caused by version incompatibility between @denops/core and @denops/test.

📝 Description

What Changed

Updated denoland/setup-deno@v1.1.4 to denoland/setup-deno@v2 in the test job
Downgraded @denops/core from v8.0.0 back to v7.0.0

Root Cause

The CI started failing after upgrading @denops/core from v7 to v8. The issue is that @denops/test v3.0.4 is hardcoded to use @denops/core@^7.0.0, creating a version conflict when the project uses v8.

This mismatch caused runtime errors that manifested as "TypeError: callback is not a function" in fs.close() when running tests in the Linux CI environment.

🔄 Type of Change

🐛 Bug fix (non-breaking change fixing an issue)
📦 Dependency change

🧪 Testing

Root Cause Analysis

Tests pass locally with Deno 2.3.0 on macOS
Tests fail in CI with Deno 2.3.0 on Ubuntu
Investigation revealed @denops/test imports @denops/core v7 while project specified v8
This version conflict caused the fs.close() errors

Expected Result

With @denops/core downgraded to v7, both the project and @denops/test will use the same version, eliminating the conflict.

✅ Checklist

Code Quality

My code follows the project's style guidelines
I have performed a self-review of my changes

Testing

The changes address the root cause of CI failures
All workflow jobs now use consistent setup-deno versions

🔗 Related Issues

Fixes CI failures that started from: c720851

📊 Impact

This temporarily downgrades @denops/core to v7 to maintain compatibility with @denops/test. When @denops/test is updated to support v8, the project can upgrade again.

📝 Next Steps

Monitor for @denops/test updates that support @denops/core v8
File an issue with vim-denops/deno-denops-test to request v8 support

Summary by CodeRabbit

Chores
- Updated CI test workflow to use a newer major version of the Deno setup action for improved reliability and maintenance.
Tests
- Adjusted test tooling dependency range to align with current tooling and ensure consistent module resolution.

coderabbitai · 2025-09-28T17:16:47Z

Walkthrough

Updated CI workflow to use denoland/setup-deno@v2 and changed the @denops/test import mapping in deno.jsonc from jsr:@denops/test@^3.0.4 to jsr:@denops/test@^3.0.0. No runtime code or exported APIs changed.

Changes

Cohort / File(s)	Summary
CI workflow action bump `\.github/workflows/test.yml`	Updated action reference from `denoland/setup-deno@v1.1.4` to `denoland/setup-deno@v2`.
Deno import mapping change `deno.jsonc`	Modified `imports` entry for `@denops/test` from `jsr:@denops/test@^3.0.4` to `jsr:@denops/test@^3.0.0`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Update development toolchain configuration #290 — Similar CI change updating denoland/setup-deno from v1.x to v2.
Bump versions #291 — Related change to @denops/test import mapping/version in deno.jsonc.

Suggested reviewers

lambdalisue

Poem

I nibble YAML, tweak a line,
Shift a version, tidy the vine.
Imports hop back a little bit,
Tests will run—I'll raise my mitt.
🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly highlights the core CI change—updating the setup-deno action to v2 for Deno 2.x compatibility—which aligns directly with the primary fix described in the PR objectives and clearly communicates the scope without unnecessary detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-ci

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 920594e and ca5381e.

📒 Files selected for processing (1)

deno.jsonc (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

deno.jsonc

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Deno 2.3.0 has a known bug where fs.close() requires a callback even though it should be optional according to Node.js documentation. This causes test failures with "TypeError: callback is not a function" errors. Using Deno 2.1.4 as the minimum tested version instead, while keeping 2.x for testing with the latest version. See: denoland/deno#30718

This reverts commit 59d7df9.

The CI failures are caused by msgpackr (a dependency of @denops/core v8) requiring lifecycle scripts to properly initialize its native extensions. Without these scripts, tests fail with "TypeError: callback is not a function" errors in fs.close(). Setting nodeModulesDir to "auto" allows Deno to run these lifecycle scripts and properly initialize the msgpackr native extensions.

…test The CI failures were caused by a version mismatch between @denops/core and @denops/test. The project was using @denops/core v8, but @denops/test v3.0.4 is hardcoded to use @denops/core v7. This mismatch caused the fs.close() errors in the Linux CI environment. Until @denops/test is updated to support @denops/core v8, we need to stay on v7 to maintain compatibility.

The CI failures were caused by @denops/test v3.0.4 being hardcoded to use @denops/core v7, while the project uses v8. This version mismatch caused fs.close() errors in the Linux CI environment. Updating to @denops/test v3.1.0 which supports @denops/core v8.

Shougo · 2025-09-29T00:43:01Z

@lambdalisue

diff --git a/deno.jsonc b/deno.jsonc
index 476dafd..0353732 100644
--- a/deno.jsonc
+++ b/deno.jsonc
@@ -48,7 +48,7 @@
     "@core/asyncutil": "jsr:@core/asyncutil@^1.2.0",
     "@core/unknownutil": "jsr:@core/unknownutil@^4.3.0",
     "@denops/core": "jsr:@denops/core@^8.0.0",
-    "@denops/test": "jsr:@denops/test@^3.1.0",
+    "@denops/test": "jsr:@denops/test@^3.0.0",
     "@lambdalisue/errorutil": "jsr:@lambdalisue/errorutil@^1.1.1",
     "@lambdalisue/itertools": "jsr:@lambdalisue/itertools@^1.1.2",
     "@lambdalisue/unreachable": "jsr:@lambdalisue/unreachable@^1.0.1",

fixes the error. Because denops/test 3.1.0 does not exists.

https://jsr.io/@denops/test/versions

Because denops/test 3.1.0 don't exist

Shougo · 2025-09-29T04:26:59Z

The CI started failing after upgrading @denops/core from v7 to v8. The issue is that @denops/test v3.0.4 is hardcoded to use @denops/core@^7.0.0, creating a version conflict when the project uses v8.

So denops/test must be updated to the next version?

This mismatch caused runtime errors that manifested as "TypeError: callback is not a function" in fs.close() when running tests in the Linux CI environment.

./variable/register_test.ts (uncaught error)
error: TypeError: callback is not a function
    at ext:deno_node/_fs/_fs_close.ts:17:5
    at callback (ext:deno_web/02_timers.js:58:7)
    at eventLoopTick (ext:core/01_core.js:213:13)
This error was not caught from a test and caused the test runner to fail on the referenced module.
It most likely originated from a dangling promise, event/timeout handler or top-level code.

The errors are reproduced.

Use denoland/setup-deno@v2 instead

1d9552e

lambdalisue added 5 commits September 29, 2025 02:22

Revert "fix(ci): replace Deno 2.3.0 with 2.1.4 to avoid fs.close() bug"

9f88cbd

This reverts commit 59d7df9.

Fix denops/test version

ca5381e

Because denops/test 3.1.0 don't exist

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ci): update setup-deno action to v2 for Deno 2.x compatibility #293

fix(ci): update setup-deno action to v2 for Deno 2.x compatibility #293

Uh oh!

lambdalisue commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Uh oh!

fix(ci): update setup-deno action to v2 for Deno 2.x compatibility #293

Are you sure you want to change the base?

fix(ci): update setup-deno action to v2 for Deno 2.x compatibility #293

Uh oh!

Conversation

lambdalisue commented Sep 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Purpose

📝 Description

What Changed

Root Cause

🔄 Type of Change

🧪 Testing

Root Cause Analysis

Expected Result

✅ Checklist

Code Quality

Testing

🔗 Related Issues

📊 Impact

📝 Next Steps

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Shougo commented Sep 29, 2025

Uh oh!

Uh oh!

lambdalisue commented Sep 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 28, 2025 •

edited

Loading