Merge pull request #50 from jozefhornik/cont

Fix for SELECT with OFFSET
vimeo · Jul 11, 2024 · c2cf5e5 · c2cf5e5
2 parents 3ae9c6c + 9bbc63a
commit c2cf5e5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Processor/Processor.php b/src/Processor/Processor.php
@@ -125,7 +125,7 @@ protected static function applyLimit(?LimitClause $limit, Scope $scope, QueryRes
         }
 
         return new QueryResult(
-            \array_slice($result->rows, $offset, $rowcount, true),
+            \array_slice($result->rows, $offset, $rowcount),
             $result->columns
         );
     }

diff --git a/tests/EndToEndTest.php b/tests/EndToEndTest.php
@@ -805,6 +805,18 @@ public function testSelectHavingOnAliasField()
         );
     }
 
+    public function testSelectWithOffset()
+    {
+        $pdo = self::getConnectionToFullDB(false);
+        $query = $pdo->prepare("SELECT `id` FROM `video_game_characters` ORDER BY `id` LIMIT 10000 OFFSET 1");
+        $query->execute();
+
+        $this->assertSame(
+            ['id' => 2],
+            $query->fetch(\PDO::FETCH_ASSOC)
+        );
+    }
+
     public function testLastInsertIdAfterSkippingAutoincrement()
     {
         $pdo = self::getConnectionToFullDB(false);