Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle in dsn optional dbname delimiter #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andrew-svirin
Copy link

mysql:host=mysql;port=3306;dbname=my_db is valid dsn, but does not handled correctly

@andrew-svirin
Copy link
Author

add additional commits for:

  1. Add handling of command SHOW [FULL] COLUMNS FOR {table_name}
  2. Handling multiple databases for create queries, then sql is CREATE TABLE database.table and in same script is information_schema.table
  3. Fixing PDO::getAttribute() missing method

Handling multiple databases for create queries, then sql is CREATE TABLE `database`.`table` and in same script is `information_schema`.`table`
Fixing PDO::getAttribute() missing method
Handling Multiple insert sql.
@andrew-svirin
Copy link
Author

Also committed:

  1. Populating server from sql text by multiline INSERT statements.

'Key' => in_array($name, $table_definition->primaryKeyColumns) ? 'PRI' : '',
'Default' => $column->getDefault(),
'Extra' => self::resolveExtra($column),
'Privilegies' => 'select,insert,update,references',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this typo necessary?

@andrew-svirin
Copy link
Author

Added handler for statement ALTER TABLE {table_name} AUTO_INCREMENT={N}

@andrew-svirin
Copy link
Author

Also want to thanks for this library. Tests speed was boosted 30 times for me, but all depends of amount of requests to database and it response speed.

@muglug
Copy link
Collaborator

muglug commented Oct 6, 2021

Thanks! Mind fixing the typo?

@andrew-svirin
Copy link
Author

andrew-svirin commented Oct 6, 2021

Thanks! Mind fixing the typo?
This is result of command SHOW FULL COLUMNS FROM `author`;
image
Do you mean to put empty string instead of select,insert,update,references ?

@muglug
Copy link
Collaborator

muglug commented Oct 6, 2021

You added an iPrivilegies vs Privileges

@andrew-svirin
Copy link
Author

Oh. I see. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants