Fix unused call inconsistencies/false negatives

vimeo · Feb 23, 2024 · 6125c55 · 6125c55
1 parent df1ed40
commit 6125c55
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallPurityAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallPurityAnalyzer.php
@@ -113,9 +113,10 @@ public static function analyze(
                     && !$context->inside_call
                     && !$context->inside_return
                     && !$method_storage->assertions
-                    && !$method_storage->if_true_assertions
-                    && !$method_storage->if_false_assertions
-                    && !$method_storage->throws
+                    && (!$method_storage->throws
+                        || !$context->inside_try)
+                    && !($method_storage->return_type
+                          && ($method_storage->return_type->isVoid() || $method_storage->return_type->isNever()))
                 ) {
                     IssueBuffer::maybeAdd(
                         new UnusedMethodCall(