-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master from 5.x #10683
Closed
Closed
Update master from 5.x #10683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, calling: ```php $classlikes->hasFullyQualifiedInterfaceName($i); // true $classlikes->hasFullyQualifiedClassName($i); // false $classlikes->hasFullyQualifiedInterfaceName($i); // false ``` would result in the last call returning `false`
Resolves a number of long-standing bugs ('Failed to infer case value ...') Fixes vimeo#10374 Fixes vimeo#10560 Fixes vimeo#10643 Fixes vimeo#8978
…sistent-basedir
…ctor-with-arguments
List fail tests: ``` 1) testMethodAnnotation with data set "static (string|int)[] getArray()" Undefined array key 0 /workspaces/psalm/tests/ClassLikeDocblockParserTest.php:201 2) testMethodAnnotation with data set "static (callable() : string) getCallable()" Undefined array key 0 /workspaces/psalm/tests/ClassLikeDocblockParserTest.php:201 ```
Fix parsing for code: ``` /** * @method static (string|int)[] getArray() * @method static (callable() : string) getCallable() */ class MyClass {} ``` Resolved tests: ``` 1) testMethodAnnotation with data set "static (string|int)[] getArray()" 2) testMethodAnnotation with data set "static (callable() : string) getCallable()" ```
…xes-from-parameter-names
This reverts commit 7d19f30.
Revert partial mistakenly pushed fix
ReflectionParameter::getPosition() is non-negative-int. ReflectionMethod name property is always non-empty-string. ReflectionAttribute::getTarget() returns Attribute::TARGET_* instead of int-mask. Even for attributes of promoted properties (https://3v4l.org/rpM1t). *::getAttributes() always returns a list (https://3v4l.org/LYAMb).
…correct_assertions
…in-InvalidDocblock-issue-message
weirdan
added
the
release:internal
The PR will be included in 'Internal changes' section of the release notes
label
Feb 9, 2024
I found these snippets: https://psalm.dev/r/edaea88e00<?php
interface ObjectManager
{
public function getClassMetadata(string $className): int;
}
/**
* @method stdClass getClassMetadata(int $a)
*/
interface EntityManagerInterface extends ObjectManager
{
}
function (EntityManagerInterface $em): void
{
$result = $em->getClassMetadata(stdClass::class);
/** @psalm-trace $result */;
$em->getClassMetadata('hello');
};
|
Nope, this doesn't look right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.