-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirement.txt added #153
base: feature/python3.8
Are you sure you want to change the base?
requirement.txt added #153
Conversation
Thanks for opening this pull request! 🤗 Check out few other repos below 🚀 PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kashish121 Can you please verify the dependencies mentioned in requirement.txt
?
itsdangerous==1.1.0 | ||
Jinja2==2.11.3 | ||
MarkupSafe==1.1.1 | ||
Werkzeug==1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following requirements also:
Python >= v2.7.0 || v3.7.0
Node.js >= v0.10.0
Pip >= v9.0.1
Python packages: flask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kashish121 could you tell me why this is required as pip and python is the outside dependencies means firstly then user will activate the virutalenv and then hit the python commands. @vinitshahdeo Let me know you thought also.
Description
Making a requirements.txt to install all dependencies #148
added the requirement.txt for branch features/python3.8
Fixes # (148)
Type of change
Please delete options that are not relevant.
Checklist: