Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the HTTP bind interface configurable #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

viper-admin
Copy link
Member

Pull request 🔀 created by bitbucket user tehwalris on 2019-03-14 14:01
Last updated on 2020-02-03 15:46
Original Bitbucket pull request id: 9

Source: 2be3c1a on branch tehwalris/viperserver/default
Destination: 7cc7ce5 on branch master

State: OPEN

When using ViperServer in Docker I need to connect to it from another container. For this to work, ViperServer must allow connecting from non-localhost IPs. This patch allows that as a command line option. The default behavior is unchanged.

@aterga
Copy link
Member

aterga commented Apr 25, 2020

Hi @vakaras , could you please post an update whether this PR is still useful for you? If yes, could you please explain in a few words what the purpose of TimingLog is that is extensively used in the PR. Otherwise, I'm happy to merge it.

@vakaras
Copy link
Contributor

vakaras commented Apr 26, 2020

As far as I understand, this was needed for benchmarking Viper tools. @alexanderjsummers was the supervisor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants