Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays & Clusters Caraya Conversion #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joec7598
Copy link
Contributor

Added the Caraya vi framework to unit tests that deal with array and cluster data types. These tests are under virtual folders in the project names "Arrays" and "Clusters.".

Added the Caraya vi framework to unit tests that deal with array and cluster data types. These tests are under virtual folders in the project names "Arrays" and "Clusters.".
Copy link
Contributor

@jimkring jimkring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joe. Looking great!

Let's also remove the old error handling. We don't need to raise an error, explicitly, since Caraya's Assert functions will do that for us, if the assertion fails.

image

Renamed test_openg_array.lvlib to test_openg_variant.lvlib
Removed previous error handling form tests.
General cleanup of code.
I went ahead and completed the rest of the Caraya tests under the branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants