Upset react build fixes #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeWags
force-pushed
the
upset-react-build-fixes
branch
from
324a53b to
9b316f6
Compare
JackWilb
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes none
Give a longer description of what this PR addresses and why it's needed
Previously upset-react was failing to build in NPM, causing issues with installing a new package. This resolves that issue by fixing any type errors within Upset. Interestingly, the behavior of the application is completely unaffected and was working fine before.
This fix is necessary because if a new package needs to be installed on the monorepo root level (ex: playwright), there were some interesting hoops to jump through. This fix should make it so there are no problems when setting up and running the repository.
Provide pictures/videos of the behavior before and after these changes (optional)
No behavior changes
Are there any additional TODOs before this PR is ready to go?
TODOs: