Remove buttons from attribute menu #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #345
Give a longer description of what this PR addresses and why it's needed
Removes the "Submit" and "Cancel" buttons from the attribute dropdown and instead updates the plot immediately when attributes are selected and deselected. No replacement is necessary for the "Cancel" button, as clicking off the menu closes it.
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
No
Note to reviewers
I changed the file from 4-space to 2-space indentation to be more consistent with the rest of the repo, causing Github to show a replacement diff on all indented lines. If you deselect the first commit (which contains the indentation changes and some added documentation) you'll only see the code diffs.