Show short description in alttxt pane by default #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeWags
requested changes
Apr 22, 2024
packages/app/src/components/Body.tsx
Outdated
| * @param err - The error message to convert. | ||
| * @returns The AltText object with the error message as the long description, short description, and technique description. | ||
| */ | ||
| function errToAltText(err: string): AltText { |
There was a problem hiding this comment.
What's the reasoning behind this? Could you throw an error and catch it in the calling function instead?
There was a problem hiding this comment.
Good point. This should be addressed now; I'm using errors instead. It's also hiding the "Show More" button when an error occurs.
JakeWags
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #340
Give a longer description of what this PR addresses and why it's needed
Previously, only the long description was shown in the alttxt pane. This shows the short description by default with a "Show More" button to view the long description. A "Show Less" button allows for returning to the short description.
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: