Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Size Scale Resizing #436

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix Size Scale Resizing #436

merged 4 commits into from
Dec 12, 2024

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #407

Give a longer description of what this PR addresses and why it's needed

Fixes a bug where the size axis/scale's max value wouldn't match up with the size of the largest row. Additionally, removes 2 unused files

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
407-before
After:
407-after

Have you added or updated relevant tests?

  • Yes
  • No changes are needed

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

@NateLanza NateLanza self-assigned this Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 022500f
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/675b3f67edeed90008c87b74
😎 Deploy Preview https://deploy-preview-436--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fine to merge.
Discussion point: should there be an option to lock the scale? This would make it so adding or removing sets does NOT update the scale.

@NateLanza
Copy link
Contributor Author

Looks good, fine to merge. Discussion point: should there be an option to lock the scale? This would make it so adding or removing sets does NOT update the scale.

How does that differ from the advanced scale?

@NateLanza NateLanza merged commit 52884c8 into main Dec 12, 2024
7 checks passed
@NateLanza NateLanza deleted the 407-fix-scale-resizing branch December 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing a set should trigger scale resizing
3 participants