Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayersPass: remove deprecated clearWebGL() call #9338

Merged
merged 2 commits into from
Jan 13, 2025
Merged

LayersPass: remove deprecated clearWebGL() call #9338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546f45b
LayersPass: remove deprecated clearWebGL() call
felixpalmer Jan 8, 2025
91c13d4
Merge branch 'master' into felix/layers-pass-clear-v9
felixpalmer Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions modules/core/src/passes/layers-pass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,18 @@ export default class LayersPass extends Pass {
viewport
});

// TODO v9 - remove WebGL specific logic
if (view && view.props.clear) {
const clearOpts = view.props.clear === true ? {color: true, depth: true} : view.props.clear;
this.device.withParametersWebGL(
{
scissorTest: true,
scissor: glViewport
const clearRenderPass = this.device.beginRenderPass({
framebuffer: target,
parameters: {
viewport: glViewport,
scissorRect: glViewport
},
() => this.device.clearWebGL(clearOpts)
);
clearColor: clearOpts.color ? [0, 0, 0, 0] : false,
clearDepth: clearOpts.depth ? 1 : false
});
clearRenderPass.end();
}

// render layers in normal colors
Expand Down
Loading