Skip to content

Add background border-radius to text layer #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CANEVETGASPARD
Copy link
Contributor

Closes #9004

Change List

  • Add backgroundBorderRadius prop to TextLayer.
  • Add render test for backgroundBorderRadius prop.
  • Update TextLayer api-reference documentation.

Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@CANEVETGASPARD
Copy link
Contributor Author

Hello,
In the last commits I improve encapsulation in fragment shader and add an if case for borderRadius. Then I use different values for borderRadius in test and fix documentation

@felixpalmer
Copy link
Collaborator

@CANEVETGASPARD thanks for the updates! Did you test this with sizeUnits: 'meters'? https://deck.gl/docs/api-reference/layers/text-layer#sizeunits

@CANEVETGASPARD
Copy link
Contributor Author

I tested it this morning and it worked well

@coveralls
Copy link

Coverage Status

coverage: 91.524% (+0.01%) from 91.512%
when pulling 980b9d4 on CANEVETGASPARD:issue-9004-border-radius-text-layer
into 4f5b90a on visgl:master.

@felixpalmer felixpalmer merged commit ae1829d into visgl:master Apr 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Border radius on TextLayer background
3 participants