Skip to content

fix(widgets): useWidget cleanup and add StrictMode test #9873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(widgets): useWidget cleanup and add StrictMode test #9873

wants to merge 1 commit into from

Conversation

@ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Nov 18, 2025 •
edited
Loading

For https://openjs-foundation.slack.com/archives/C05JCDKHQUE/p1763426667707549

Summary

  • ensure useWidget removes widgets regardless of index so the first widget cleans up correctly
  • add a React StrictMode regression test verifying widgets are not duplicated after remount

Testing

  • yarn test node --filter react/deckgl.spec.ts

Codex Task

@ibgreen ibgreen changed the title Fix useWidget cleanup and add StrictMode test fix(widgets): useWidget cleanup and add StrictMode test Nov 18, 2025
@ibgreen ibgreen requested a review from chrisgervang November 18, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisgervang chrisgervang Awaiting requested review from chrisgervang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ibgreen