Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have implemented a version of
CursonPaginatorbased on ideas from both:https://github.com/kitware-resonant/django-ninja-cursor-pagination/tree/master/ninja_cursor_pagination
and https://github.com/encode/django-rest-framework/blob/2465f9b4876ce16f2d22aa8d9f3cd20abde1b7c8/rest_framework/pagination.py#L583
This is an attempt for a minimal implementation that serves my needs, happy to hear any feedback.
It defines a custom paginator which can be added to any call:
It defaults to using
-createdas the positioning attribute and allows for additional ordering attributes. These, along a page_size and max_page_size can be customised per view:Where
start_dateis the positioning attribute