Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't skip unicode related tests anymore #16339

Merged
merged 6 commits into from
May 7, 2024

Conversation

sapphi-red
Copy link
Member

Description

This PR reverts #15096 as the bug (nodejs/node#48673) was fixed in node 20.12.0.

Copy link

stackblitz bot commented Apr 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red marked this pull request as ready for review April 14, 2024 10:33
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Apr 14, 2024
@sapphi-red
Copy link
Member Author

Given that more than 1 month has passed since the 20.12.0 release, I think we can now merge this PR.

@sapphi-red sapphi-red requested review from patak-dev and bluwy May 7, 2024 06:08
@bluwy bluwy merged commit c2a4ce5 into vitejs:main May 7, 2024
11 checks passed
@sapphi-red sapphi-red deleted the test/dont-skip-unicode-tests-anymore branch May 7, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants