Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle yarn command fail when root does not exist #18141

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: handle yarn command fail when root does not exist #18141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ import {
import { openBrowser as _openBrowser } from './openBrowser'
import type { TransformOptions, TransformResult } from './transformRequest'
import { transformRequest } from './transformRequest'
import { searchForWorkspaceRoot } from './searchRoot'
import { searchForPackageRoot, searchForWorkspaceRoot } from './searchRoot'
import { warmupFiles } from './warmup'
import type { DevEnvironment } from './environment'

Expand Down Expand Up @@ -1042,14 +1042,17 @@ export function resolveServerOptions(
}

if (process.versions.pnp) {
// running a command fails if cwd doesn't exist and root may not exist
// search for package root to find a path that exists
const cwd = searchForPackageRoot(root)
try {
const enableGlobalCache =
execSync('yarn config get enableGlobalCache', { cwd: root })
execSync('yarn config get enableGlobalCache', { cwd })
.toString()
.trim() === 'true'
const yarnCacheDir = execSync(
`yarn config get ${enableGlobalCache ? 'globalFolder' : 'cacheFolder'}`,
{ cwd: root },
{ cwd },
)
.toString()
.trim()
Expand Down