Skip to content

Conversation

btea
Copy link
Contributor

@btea btea commented Oct 13, 2025

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. There's a slight improvement from 8s to 6s locally. On CI, it seems to be 16s to 13s.

Can you also add the option to the other calls?

vite/package.json

Lines 83 to 91 in 3a92bc7

"packages/*/{src,types}/**/*.ts": [
"eslint --cache --fix"
],
"packages/**/*.d.ts": [
"eslint --cache --fix"
],
"playground/**/__tests__/**/*.ts": [
"eslint --cache --fix"
]

@btea
Copy link
Contributor Author

btea commented Oct 13, 2025

Thanks, that has been edited.

bluwy
bluwy previously approved these changes Oct 13, 2025
@sapphi-red
Copy link
Member

On my machine, it seems this change speeds up when there's no cache, but slow downs when there's a cache.

With cache: 2.007s -> 5.700s
Without cache: 20.436s -> 10.826s

@bluwy Did you try with cache or without cache (delete .eslintcache)?

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Oct 14, 2025
@btea
Copy link
Contributor Author

btea commented Oct 14, 2025

On my machine, the performance is about the same with the cache parameter, and is higher without the cache. 🤔

@bluwy
Copy link
Member

bluwy commented Oct 14, 2025

@bluwy Did you try with cache or without cache (delete .eslintcache)?

I was testing without cache. With cache, there's not much improvement for me, maybe 50ms faster at most.

"overrides": [
{
"files": ["*.json5"],
"files": ["**/*.json5"],
Copy link
Contributor Author

@btea btea Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid adding --experimental-cli option and causing overrides configuration to not take effect. refer to prettier/prettier-cli#70 (comment)

"postinstall": "simple-git-hooks",
"format": "prettier --write --cache .",
"lint": "eslint --cache .",
"format": "prettier --write --cache . --experimental-cli",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants