-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
chore: lint
script add concurrency
option
#20927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: lint
script add concurrency
option
#20927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. There's a slight improvement from 8s to 6s locally. On CI, it seems to be 16s to 13s.
Can you also add the option to the other calls?
Lines 83 to 91 in 3a92bc7
"packages/*/{src,types}/**/*.ts": [ | |
"eslint --cache --fix" | |
], | |
"packages/**/*.d.ts": [ | |
"eslint --cache --fix" | |
], | |
"playground/**/__tests__/**/*.ts": [ | |
"eslint --cache --fix" | |
] |
Thanks, that has been edited. |
On my machine, it seems this change speeds up when there's no cache, but slow downs when there's a cache. With cache: 2.007s -> 5.700s @bluwy Did you try with cache or without cache (delete |
On my machine, the performance is about the same with the cache parameter, and is higher without the cache. 🤔 |
I was testing without cache. With cache, there's not much improvement for me, maybe 50ms faster at most. |
"overrides": [ | ||
{ | ||
"files": ["*.json5"], | ||
"files": ["**/*.json5"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid adding --experimental-cli
option and causing overrides configuration to not take effect. refer to prettier/prettier-cli#70 (comment)
"postinstall": "simple-git-hooks", | ||
"format": "prettier --write --cache .", | ||
"lint": "eslint --cache .", | ||
"format": "prettier --write --cache . --experimental-cli", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
https://eslint.org/docs/latest/use/command-line-interface#--concurrency