feat: add server.hmr.update
to allow configuring ws settings while disabling HMR
#20961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that it's not possible to configure the ws settings when the HMR is disabled by
server.hmr: false
. This PR addsserver.hmr.update: false
option which works similarly toserver.hmr: false
.The alternative way is to move all ws related options under
server.ws
. This feels more correct, but I'm not sure if the required migration effort for the users is worth.fixes #18489
refs #18489 (comment), #18489 (comment),