Skip to content

chore: use npmx badge#21589

Open
btea wants to merge 3 commits intovitejs:mainfrom
btea:chore/use-npmx-badge
Open

chore: use npmx badge#21589
btea wants to merge 3 commits intovitejs:mainfrom
btea:chore/use-npmx-badge

Conversation

@btea
Copy link
Contributor

@btea btea commented Feb 8, 2026

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The engine badge doesn't seem to be legible. The white text on yellow background is hard to read for me. I think we should resolve this before merging.

Other than that, the shading and spacing is a bit different compared to the github and discord badges but it's not a big deal for me.

@btea
Copy link
Contributor Author

btea commented Feb 8, 2026

The engine badge doesn't seem to be legible. The white text on yellow background is hard to read for me. I think we should resolve this before merging.

The background color has been changed to the same color as the original badge.

@bluwy
Copy link
Member

bluwy commented Feb 8, 2026

Not sure if it's a caching issue, but it still looks the same to me.
image

@btea
Copy link
Contributor Author

btea commented Feb 9, 2026

Yes, it should be a caching issue; I've already made changes on the npmx side. npmx-dev/npmx.dev#1246

@sapphi-red
Copy link
Member

sapphi-red commented Feb 9, 2026

I'd prefer the design to be consistent among all the badges. I also think the font size got too small.

@btea
Copy link
Contributor Author

btea commented Feb 10, 2026

I'd prefer the design to be consistent among all the badges.

Do you mean to change the badges of CI and Discord to those of npmx?

I also think the font size got too small.

The font size should be the same for all of them, 11px.

@bluwy
Copy link
Member

bluwy commented Feb 10, 2026

The font size should be the same for all of them, 11px.

It's related to the font-family I think. npmx has font-family="'Geist', system-ui, -apple-system, sans-serif" while shields.io font-family="Verdana,Geneva,DejaVu Sans,sans-serif". The one from shields.io does look better to me by a bit.

@sapphi-red
Copy link
Member

Do you mean to change the badges of CI and Discord to those of npmx?

Yeah, either changing the style of the badges from npmx to align the CI and Discord ones, or changing the style of CI and Discord ones to align the npmx ones.

The font size should be the same for all of them, 11px.

Ah, probably that's the cause. I think Geist doesn't work here as I (and many people) don't have it installed and the SVG doesn't have a @font-face. I have a smaller font set as the UI font for my machine so it looks like this.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants