Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/vite/src/node/__tests__/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
getServerUrlByHost,
injectQuery,
isFileReadable,
isInNodeModules,
isParentDirectory,
mergeWithDefaults,
normalizePath,
Expand Down Expand Up @@ -1058,3 +1059,38 @@ describe('resolveServerUrls', () => {
expect(result.local).toContain('https://localhost:3000/')
})
})

describe('isInNodeModules', () => {
test('should return true for paths containing /node_modules/ as a directory', () => {
expect(isInNodeModules('/path/to/node_modules/package/index.js')).toBe(true)
expect(isInNodeModules('/project/node_modules/.vite/dep.js')).toBe(true)
expect(
isInNodeModules('C:/Users/user/project/node_modules/foo/bar.js'),
).toBe(true)
})

test('should return false for paths containing node_modules as substring of directory name', () => {
expect(isInNodeModules('/path/to/node_modules_bug/index.js')).toBe(false)
expect(isInNodeModules('/path/to/my_node_modules/index.js')).toBe(false)
expect(isInNodeModules('/path/to/node_modules_test/src/main.ts')).toBe(
false,
)
})

test('should return true for backslash paths on Windows', () => {
expect(
isInNodeModules('C:\\Users\\user\\project\\node_modules\\foo\\bar.js'),
).toBe(true)
})

test('should return false for backslash paths with node_modules as substring', () => {
expect(isInNodeModules('C:\\Users\\user\\node_modules_bug\\index.js')).toBe(
false,
)
})

test('should return false when node_modules is not present', () => {
expect(isInNodeModules('/path/to/project/src/main.ts')).toBe(false)
expect(isInNodeModules('/path/to/project/index.html')).toBe(false)
})
})
2 changes: 1 addition & 1 deletion packages/vite/src/node/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export function isNodeBuiltin(id: string): boolean {
}

export function isInNodeModules(id: string): boolean {
return id.includes('node_modules')
return id.includes('/node_modules/') || id.includes('\\node_modules\\')
}

export function moduleListContains(
Expand Down