Skip to content

fix: strip import attributes from dynamic imports to fix Firefox compatibility #21680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IMaloney wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Draft

fix: strip import attributes from dynamic imports to fix Firefox compatibility #21680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/importAnalysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
const isDynamicImport = dynamicIndex > -1

// strip import attributes as we can process them ourselves
if (!isDynamicImport && attributeIndex > -1) {
if (attributeIndex > -1) {
str().remove(end + 1, expEnd)
}

Expand Down
4 changes: 4 additions & 0 deletions playground/import-assertion/__tests__/import-assertion.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ test('from source code', async () => {
test('from dependency', async () => {
expect(await page.textContent('.dep'), 'world')
})

test('dynamic import with attributes', async () => {
expect(await page.textContent('.dynamic'), 'bar')
})
6 changes: 6 additions & 0 deletions playground/import-assertion/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@ <h2>From source code</h2>
<h2>From dependency</h2>
<p class="dep"></p>

<p class="dynamic"></p>

<script type="module">
import * as data from './data.json' assert { type: 'json' }
text('.src', data.foo)

import * as depData from '@vitejs/test-import-assertion-dep'
text('.dep', depData.hello)

import('./data.json', { with: { type: 'json' } }).then((m) =>
text('.dynamic', m.foo),
)

function text(el, text) {
document.querySelector(el).textContent = text
}
Expand Down
Loading