Skip to content

test: add more type tests for defineConfig#21698

Merged
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/allow-define-config-with-callback-without-as-const
Feb 26, 2026
Merged

test: add more type tests for defineConfig#21698
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/allow-define-config-with-callback-without-as-const

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 24, 2026

refs #21684

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 24, 2026
@sapphi-red
Copy link
Member Author

Hmm, ok this seems to break things. Let's keep the types as-is but add the tests

@sapphi-red sapphi-red changed the title feat: allow defineConfig with callback without as const test: add more type tests for defineConfig Feb 24, 2026
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test and removed p2-nice-to-have Not breaking anything but nice to have (priority) labels Feb 24, 2026
@sapphi-red sapphi-red marked this pull request as ready for review February 24, 2026 06:33
@sapphi-red sapphi-red merged commit 4fedbbd into vitejs:main Feb 26, 2026
23 checks passed
@sapphi-red sapphi-red deleted the feat/allow-define-config-with-callback-without-as-const branch February 26, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants