fix(docs): new Request() will not work without a host#21709
Open
cyco130 wants to merge 1 commit intovitejs:mainfrom
Open
fix(docs): new Request() will not work without a host#21709cyco130 wants to merge 1 commit intovitejs:mainfrom
cyco130 wants to merge 1 commit intovitejs:mainfrom
Conversation
The examples in the docs use bare URLs with the `Request` constructor like `new Request('/request-to-handle')` but in Node, this constructor requires a full URL with a host, otherwise a `TypeError: Failed to parse URL from /request-to-handle` will be thrown.
But this is not a complete fix, we need to explain where the `HOST_NAME` constant will come from and what it should contain.
Opening this PR to start the discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FetchableDevEnvironmentexamples in the docs use bare URLs with theRequestconstructor likenew Request('/request-to-handle')but in Node, this constructor requires a full URL with a host, otherwise aTypeError: Failed to parse URL from /request-to-handlewill be thrown.But this is not a complete fix, we need to explain where the
HOST_NAMEconstant will come from and what it should contain. If we don't care about the actual host, a simplehttp://example.comwill work but it would be confusing and require some explanation at least.Opening this PR to start the discussion.