update error message

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
vitessio · Dec 26, 2024 · 3c28e2f · 3c28e2f
1 parent 0fc2fe9
commit 3c28e2f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/go/vt/vtgate/planbuilder/operators/delete.go b/go/vt/vtgate/planbuilder/operators/delete.go
@@ -322,7 +322,7 @@ func updateQueryGraphWithSource(ctx *plancontext.PlanningContext, input Operator
 			return op, NoRewrite
 		}
 		if len(qg.Tables) > 1 {
-			panic(vterrors.VT12001("DELETE on reference table with join"))
+			panic(vterrors.VT12001("DML on reference table with join"))
 		}
 		for _, tbl := range qg.Tables {
 			if tbl.ID != tblID {

diff --git a/go/vt/vtgate/planbuilder/plan_test.go b/go/vt/vtgate/planbuilder/plan_test.go
@@ -668,7 +668,7 @@ func (s *planTestSuite) testFile(filename string, vschema *vschemawrapper.VSchem
 			current := PlanTest{
 				Comment: tcase.Comment,
 				Query:   tcase.Query,
-				SkipE2E: true,
+				SkipE2E: tcase.SkipE2E,
 			}
 			vschema.Version = Gen4
 			out := getPlanOutput(tcase, vschema, render)

diff --git a/go/vt/vtgate/planbuilder/testdata/unsupported_cases.json b/go/vt/vtgate/planbuilder/testdata/unsupported_cases.json
@@ -342,7 +342,12 @@
   {
     "comment": "reference table delete with join",
     "query": "delete r from user u join ref_with_source r on u.col = r.col",
-    "plan": "VT12001: unsupported: DELETE on reference table with join"
+    "plan": "VT12001: unsupported: DML on reference table with join"
+  },
+  {
+    "comment": "reference table update with join",
+    "query": "update user u join ref_with_source r on u.col = r.col set r.col = 5",
+    "plan": "VT12001: unsupported: DML on reference table with join"
   },
   {
     "comment": "group_concat unsupported when needs full evaluation at vtgate with more than 1 column",