Add support for row_alias syntax added in MySQL 8.0.19. (#15510)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
vitessio · Apr 4, 2024 · 97890a7 · 97890a7
1 parent 6c2c895
commit 97890a7
Show file tree

Hide file tree

Showing 12 changed files with 7,377 additions and 7,185 deletions.
diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -342,6 +342,7 @@ type (
 		Columns    Columns
 		Rows       InsertRows
 		OnDup      OnDup
+		RowAlias   *RowAlias
 	}
 
 	// Ignore represents whether ignore was specified or not
@@ -3492,6 +3493,11 @@ type SetExpr struct {
 // OnDup represents an ON DUPLICATE KEY clause.
 type OnDup UpdateExprs
 
+type RowAlias struct {
+	TableName IdentifierCS
+	Columns   Columns
+}
+
 // IdentifierCI is a case insensitive SQL identifier. It will be escaped with
 // backquotes if necessary.
 type IdentifierCI struct {

diff --git a/go/vt/sqlparser/ast_clone.go b/go/vt/sqlparser/ast_clone.go
diff --git a/go/vt/sqlparser/ast_copy_on_rewrite.go b/go/vt/sqlparser/ast_copy_on_rewrite.go
diff --git a/go/vt/sqlparser/ast_equals.go b/go/vt/sqlparser/ast_equals.go
diff --git a/go/vt/sqlparser/ast_format.go b/go/vt/sqlparser/ast_format.go
@@ -117,20 +117,20 @@ func (node *Stream) Format(buf *TrackedBuffer) {
 func (node *Insert) Format(buf *TrackedBuffer) {
 	switch node.Action {
 	case InsertAct:
-		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v",
+		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v%v",
 			InsertStr,
 			node.Comments, node.Ignore.ToString(),
-			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.OnDup)
+			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.RowAlias, node.OnDup)
 	case ReplaceAct:
-		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v",
+		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v%v",
 			ReplaceStr,
 			node.Comments, node.Ignore.ToString(),
-			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.OnDup)
+			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.RowAlias, node.OnDup)
 	default:
-		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v",
+		buf.astPrintf(node, "%s %v%sinto %v%v%v %v%v%v",
 			"Unkown Insert Action",
 			node.Comments, node.Ignore.ToString(),
-			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.OnDup)
+			node.Table.Expr, node.Partitions, node.Columns, node.Rows, node.RowAlias, node.OnDup)
 	}
 
 }
@@ -2010,6 +2010,18 @@ func (node OnDup) Format(buf *TrackedBuffer) {
 	buf.astPrintf(node, " on duplicate key update %v", UpdateExprs(node))
 }
 
+func (node *RowAlias) Format(buf *TrackedBuffer) {
+	if node == nil {
+		return
+	}
+
+	buf.astPrintf(node, " as %v", node.TableName)
+
+	if node.Columns != nil {
+		buf.astPrintf(node, " %v", node.Columns)
+	}
+}
+
 // Format formats the node.
 func (node IdentifierCI) Format(buf *TrackedBuffer) {
 	if node.IsEmpty() {

diff --git a/go/vt/sqlparser/ast_format_fast.go b/go/vt/sqlparser/ast_format_fast.go
diff --git a/go/vt/sqlparser/ast_rewrite.go b/go/vt/sqlparser/ast_rewrite.go
diff --git a/go/vt/sqlparser/ast_visit.go b/go/vt/sqlparser/ast_visit.go
diff --git a/go/vt/sqlparser/cached_size.go b/go/vt/sqlparser/cached_size.go
diff --git a/go/vt/sqlparser/parse_test.go b/go/vt/sqlparser/parse_test.go
@@ -1298,6 +1298,12 @@ var (
 		input: "insert /* bool in on duplicate */ into a values (1, 2, 3) on duplicate key update b = values(b), c = d",
 	}, {
 		input: "insert /* bool in on duplicate */ into a values (1, 2, 3) on duplicate key update b = values(a.b), c = d",
+	}, {
+		input:  "insert into a values (1, 2, 3) as `a_values`",
+		output: "insert into a values (1, 2, 3) as a_values",
+	}, {
+		input:  "insert into a values (1, 2, 3) as `a_values` (`foo`, bar, baz)",
+		output: "insert into a values (1, 2, 3) as a_values (foo, bar, baz)",
 	}, {
 		input: "insert /* bool expression on duplicate */ into a values (1, 2) on duplicate key update b = func(a), c = a > d",
 	}, {